fix: offsetTop and offsetLeft should relative to body element if no positioned parent found #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temper357
requested review from
andycall,
wssgcg1213,
yuanyan and
answershuto
yuanyan
reviewed
Dec 31, 2021
wssgcg1213
previously approved these changes
Jan 4, 2022
wssgcg1213
reviewed
Jan 4, 2022
| || renderStyle.position == CSSPositionType.fixed | ||
| || this is BodyElement | ||
| || this == ownerDocument.documentElement) { | ||
| return null; |
There was a problem hiding this comment.
这里文档里说的 terminate 我感觉是直接返回当前对象, 不过效率上这样更好一点, 所以我 accept 了
wssgcg1213
reviewed
Jan 4, 2022
wssgcg1213
approved these changes
Jan 6, 2022
answershuto
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1000