feat: input should blur when click other target. #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
answershuto
commented
Jan 5, 2022
•
answershuto
commented
- input 点击其他区域失焦
- 修改 input placeholder 颜色
wssgcg1213
reviewed
Jan 5, 2022
wssgcg1213
reviewed
Jan 5, 2022
wssgcg1213
reviewed
Jan 5, 2022
| : super(context, defaultStyle: defaultStyle); | ||
| : super(context, defaultStyle: defaultStyle) { | ||
| // Since the bubbling process is in bridge, we need to globally hijack click for focus shifting, so you need to listen here. | ||
| addEvent('click'); |
There was a problem hiding this comment.
没有，这个是增加方法注册使 gestureManager 判断整个 hittest 链路上有节点在监听，否则会被直接优化掉不执行。
wssgcg1213
reviewed
Jan 5, 2022
| @@ -222,6 +222,7 @@ class InputElement extends Element implements TextInputClient, TickerProvider { | |||
| // TODO: support ::placeholder pseudo element | |||
| return _buildTextSpan( | |||
| text: placeholderText, | |||
| color: Color.fromARGB(255, 169, 169, 169) | |||
wssgcg1213
reviewed
Jan 5, 2022
kraken/lib/src/dom/node.dart
Outdated
| @@ -287,6 +287,9 @@ abstract class Node extends EventTarget implements RenderObjectNode, LifecycleCa | |||
| ownerDocument.gestureListener?.onTouchEnd!(event as TouchEvent); | |||
temper357
reviewed
Jan 5, 2022
| void shiftFocus(EventTarget target) { | ||
| InputElement? inputElement = InputElement.focusInputElement; | ||
| if (inputElement != null && inputElement != target) { | ||
| InputElement.focusInputElement?.blur(); |
temper357
reviewed
Jan 5, 2022
| @@ -895,6 +902,13 @@ class KrakenController { | |||
| } | |||
| } | |||
|
|
|||
| void dispatchEvent(Event event) { | |||
| EventTarget? target = event.target; | |||
| if (event.type == 'click' && target != null) { | |||
temper357
reviewed
Jan 5, 2022
| @@ -193,6 +193,13 @@ class KrakenViewController | |||
| late Document document; | |||
| late Window window; | |||
|
|
|||
| void shiftFocus(EventTarget target) { | |||
| InputElement? inputElement = InputElement.focusInputElement; | |||
| if (inputElement != null && inputElement != target) { | |||
There was a problem hiding this comment.
这个加个 TODO 好了，未来如果有其他 element 也能获取焦点，这里的逻辑要改
wssgcg1213
previously approved these changes
Jan 6, 2022
temper357
approved these changes
Jan 6, 2022
wssgcg1213
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.