Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: input hotkey and delete command fail due to flutter 2.5 upgrade #1096

Merged
merged 1 commit into from Jan 14, 2022
Merged

fix: input hotkey and delete command fail due to flutter 2.5 upgrade #1096

merged 1 commit into from Jan 14, 2022

Conversation

temper357
Copy link
Contributor

@temper357 temper357 commented Jan 13, 2022 •
edited

Closes #1092

  1. 在 Kraken 的 widget 中 override 系统的 action，补充 RenderEditable 在 Flutter 2.5 版本中被移除的 delete 及 hotKey 对应的 action。
  2. 通过 diff Flutter 2.2 与 2.5 版本的 editable_text.dart （对应 Kraken 拷贝出来修改的 input.dart），发现一处 _selectionOverlay 相关的逻辑变更，同步到 Kraken。

@wssgcg1213 wssgcg1213 merged commit d6d7af3 into main Jan 14, 2022
@wssgcg1213 wssgcg1213 deleted the fix/input-hotkey-fail branch January 14, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

@answershuto answershuto answershuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter 升级到 2.5 后 Input 内文本无法删除
3 participants
@temper357 @wssgcg1213 @answershuto