Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: object-fit not work due to image resize optimization #1165

Merged
merged 42 commits into from
Feb 23, 2022
Merged

fix: object-fit not work due to image resize optimization #1165

merged 42 commits into from
Feb 23, 2022

Commits on Feb 14, 2022

  1. fix: object-fit cover/contain fail

    @temper357
    temper357 committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    ffc9d81 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. feat: move resize logic to image provider to get natural size.

    @temper357
    temper357 committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    1bca9db View commit details
    Browse the repository at this point in the history

  2. chore: add comment

    @temper357
    temper357 committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    68f5557 View commit details
    Browse the repository at this point in the history

  3. test: add tests.

    @temper357
    temper357 committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    6856494 View commit details
    Browse the repository at this point in the history

  4. fix: null safety

    @temper357
    temper357 committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    0db4821 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. chore: temp test for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    dc1b24c View commit details
    Browse the repository at this point in the history

  2. chore: revert test code

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    de1e981 View commit details
    Browse the repository at this point in the history

  3. test: disable tests for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    776b601 View commit details
    Browse the repository at this point in the history

  4. test: disable tests for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    90217ce View commit details
    Browse the repository at this point in the history

  5. test: disable tests for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    a8d457a View commit details
    Browse the repository at this point in the history

  6. test: disable tests for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    b1a3ccc View commit details
    Browse the repository at this point in the history

  7. test: disable tests for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    64e7556 View commit details
    Browse the repository at this point in the history

  8. test: disable tests for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    378abc7 View commit details
    Browse the repository at this point in the history

  9. chore: mod test for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    0c51fd2 View commit details
    Browse the repository at this point in the history

  10. chore: mod test for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    5ba6fdb View commit details
    Browse the repository at this point in the history

  11. chore: mod test for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    42aee0f View commit details
    Browse the repository at this point in the history

  12. chore: mod test for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    cb38deb View commit details
    Browse the repository at this point in the history

  13. fix: image no resize due to not consider device pixel ratio while com… 

    …paring to natural size
    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    0c48057 View commit details
    Browse the repository at this point in the history

  14. chore: debug for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    7ded56f View commit details
    Browse the repository at this point in the history

  15. chore: debug for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    803574e View commit details
    Browse the repository at this point in the history

  16. chore: debug for ci

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    fd51bbd View commit details
    Browse the repository at this point in the history

  17. feat: add objectFit param to cached image key

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    d891952 View commit details
    Browse the repository at this point in the history

  18. chore: remove debug

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    d70fd86 View commit details
    Browse the repository at this point in the history

  19. chore: disable test for debug

    @temper357
    temper357 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    fbc3b3d View commit details
    Browse the repository at this point in the history

  20. test: update snapshots

    @andycall
    andycall committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    28fed03 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. test: update snapshots

    @temper357
    temper357 committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    5202608 View commit details
    Browse the repository at this point in the history

  2. feat: new CachedAssetImage to add objectFit to obtainKey

    @temper357
    temper357 committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    993fe04 View commit details
    Browse the repository at this point in the history

  3. feat: add image resize logic of object-fit none and scale-down

    @temper357
    temper357 committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    9552a9f View commit details
    Browse the repository at this point in the history

  4. test: update snapshots

    @andycall
    andycall committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    04e1928 View commit details
    Browse the repository at this point in the history

  5. test: add object-fit none and scale-down tests

    @temper357
    temper357 committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    fed03ff View commit details
    Browse the repository at this point in the history

  6. Merge branch 'fix/object-fit' of github.com:openkraken/kraken into fi… 

    …x/object-fit
    @temper357
    temper357 committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    44f6b7a View commit details
    Browse the repository at this point in the history

  7. test: add snapshots.

    @andycall
    andycall committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    49abcc4 View commit details
    Browse the repository at this point in the history

  8. feat: add object-fit key for assetImage, fileImage and memoryImage pr… 

    …ovider
    @temper357
    temper357 committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    7808c56 View commit details
    Browse the repository at this point in the history

  9. fix: memory image and file image provider

    @temper357
    temper357 committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    e6e30c9 View commit details
    Browse the repository at this point in the history

  10. fix: lint

    @temper357
    temper357 committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    27c7808 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. feat: resize image with aspect radio maintained when object-fit is fill

    @temper357
    temper357 committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    ad15c3d View commit details
    Browse the repository at this point in the history

  2. fix: object-fit should be get from renderStyle on element directly

    @temper357
    temper357 committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    1afaf8a View commit details
    Browse the repository at this point in the history

  3. test: update snapshots

    @temper357
    temper357 committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    aebf0c3 View commit details
    Browse the repository at this point in the history

  4. feat: add scaling property to image element to enable image scale.

    @temper357
    temper357 committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    23fbd77 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. fix: only need to resolve image when scaling is scale

    @temper357
    temper357 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    f5d1f90 View commit details
    Browse the repository at this point in the history

  2. test: add test for scaling scale

    @temper357
    temper357 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    584dabc View commit details
    Browse the repository at this point in the history

  3. test: update snapshots

    @andycall
    andycall committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    0349988 View commit details
    Browse the repository at this point in the history