Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style set to empty string #1220

Merged
merged 8 commits into from
Mar 22, 2022
Merged

fix: style set to empty string #1220

merged 8 commits into from
Mar 22, 2022

Conversation

temper357
Copy link
Contributor

Closes #1219

  • 对于有默认值的 css 样式,将其设置成空字符串会将样式重置为默认值,kraken 会将空字符串转换成 null 设置给 renderStyle 上的样式,部分样式未支持 null 导致报错。


void set visibility(Visibility value) {
void set visibility(Visibility? value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 void 下次看到可以删掉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那这次删了呗 =。=

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非本次 PR 引入的问题原则上可以不要求本次 PR 一定解决

wssgcg1213
wssgcg1213 previously approved these changes Mar 22, 2022
wssgcg1213
wssgcg1213 previously approved these changes Mar 22, 2022
@answershuto answershuto merged commit 31615b3 into main Mar 22, 2022
@answershuto answershuto deleted the fix/style-set-to-empty branch March 22, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

点击 rax-modal 组件关闭遮罩层时报错
4 participants