Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/asset protocol #1232

Merged
merged 11 commits into from Mar 22, 2022
Merged

Fix/asset protocol #1232

merged 11 commits into from Mar 22, 2022

Conversation

wssgcg1213
Copy link
Member

@wssgcg1213 wssgcg1213 commented Mar 21, 2022 •
edited

修复一些 assets 协议使用的问题

  1. 修复 assets 协议加载图片失败的问题, Same as fix: Unable to handle Asset scheme #1227
    1.1 修复了测试里添加 UriParser 纠正访问 assets 路径的方法
  2. 删除从未使用且从未对外透出的 AppManifest 功能
  3. 优化 example 示例, 使用 html 做入口, 使用 CSS 书写样式, 使用外联 JS 执行部分逻辑

image

4. 默认 url 为 about:blank, 并不渲染任何内容，与 WebView 保持一致

@wssgcg1213 wssgcg1213 mentioned this pull request Mar 21, 2022
Closed
devjiangzhou
devjiangzhou previously approved these changes Mar 21, 2022
View reviewed changes
kraken/lib/src/launcher/bundle.dart Outdated Show resolved Hide resolved
@answershuto
Copy link
Member

CI 没过

@wssgcg1213 wssgcg1213 merged commit de3a664 into main Mar 22, 2022
@wssgcg1213 wssgcg1213 deleted the fix/asset-protocol branch March 22, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devjiangzhou devjiangzhou devjiangzhou approved these changes

@answershuto answershuto answershuto approved these changes

@andycall andycall Awaiting requested review from andycall

@yuanyan yuanyan Awaiting requested review from yuanyan

@temper357 temper357 Awaiting requested review from temper357

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wssgcg1213 @answershuto @devjiangzhou