Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file protocol and test cases #1234

Merged
merged 17 commits into from Mar 24, 2022
Merged

fix: file protocol and test cases #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ec83177
fix: file protocol and test cases
wssgcg1213 Mar 22, 2022
72870e6
refactor: asset -> assets
wssgcg1213 Mar 22, 2022
772f971
test: for test
wssgcg1213 Mar 22, 2022
f65d1b3
chore: Inject a custom user agent, to avoid reading from bridge.
wssgcg1213 Mar 22, 2022
d61d13f
refactor: kraken bundle
wssgcg1213 Mar 23, 2022
41a1db5
chore: analysis problem
wssgcg1213 Mar 23, 2022
2ebc702
fix: layer check
wssgcg1213 Mar 23, 2022
eba0fd2
refactor: isResolved to indicate data is obtained.
wssgcg1213 Mar 23, 2022
4f5c22a
chore: add performance future
wssgcg1213 Mar 23, 2022
2573e77
fix: add async to support FutureOr<String>
wssgcg1213 Mar 23, 2022
d98a8fb
fix: compute must receive static method
wssgcg1213 Mar 23, 2022
d8f1ebd
chore: rename
wssgcg1213 Mar 23, 2022
9f95ed2
Update bundle.dart
yuanyan Mar 23, 2022
aeb92d6
chore: update mime type variable identifier
wssgcg1213 Mar 24, 2022
5cc9d5b
Merge branch 'fix/file-protocol' of github.com:openkraken/kraken into…
wssgcg1213 Mar 24, 2022
fd77993
refactor: mime
wssgcg1213 Mar 24, 2022
f3805ca
chore: update bundle
wssgcg1213 Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 1 addition & 8 deletions kraken/lib/src/dom/element.dart
View file
Open in desktop
Expand Up @@ -1558,8 +1558,6 @@ abstract class Element
}

Future<Uint8List> toBlob({ double? devicePixelRatio }) {
devicePixelRatio ??= window.devicePixelRatio;

Completer<Uint8List> completer = Completer();
forceToRepaintBoundary = true;
renderBoxModel!.owner!.flushLayout();
Expand All @@ -1568,16 +1566,11 @@ abstract class Element
Uint8List captured;
RenderBoxModel _renderBoxModel = renderBoxModel!;

// If prev flush paint with error, render object keeps NEEDS-PAINT flag,
// will cause layer not exists.
assert(!_renderBoxModel.debugNeedsPaint, () {
debugPrint('Failed toBlob at $this, flush painting may raise error.');
});
if (_renderBoxModel.hasSize && _renderBoxModel.size.isEmpty) {
// Return a blob with zero length.
captured = Uint8List(0);
} else {
Image image = await _renderBoxModel.toImage(pixelRatio: devicePixelRatio!);
Image image = await _renderBoxModel.toImage(pixelRatio: devicePixelRatio ?? window.devicePixelRatio);
ByteData? byteData = await image.toByteData(format: ImageByteFormat.png);
captured = byteData!.buffer.asUint8List();
}
Expand Down
6 changes: 3 additions & 3 deletions kraken/lib/src/dom/elements/head.dart
View file
Open in desktop
Expand Up @@ -117,7 +117,7 @@ class LinkElement extends Element {
try {
KrakenBundle bundle = KrakenBundle.fromUrl(url);
await bundle.resolve(contextId);
bundle.eval(contextId);
await bundle.eval(contextId);

// Successful load.
SchedulerBinding.instance!.addPostFrameCallback((_) {
Expand Down Expand Up @@ -278,7 +278,7 @@ class ScriptElement extends Element {
try {
KrakenBundle bundle = KrakenBundle.fromUrl(src.toString());
await bundle.resolve(contextId);
bundle.eval(contextId);
await bundle.eval(contextId);
// Successful load.
SchedulerBinding.instance!.addPostFrameCallback((_) {
dispatchEvent(Event(EVENT_LOAD));
Expand Down Expand Up @@ -309,7 +309,7 @@ class ScriptElement extends Element {
if (controller != null) {
KrakenBundle bundle = KrakenBundle.fromContent(script, url: controller.url);
await bundle.resolve(contextId);
bundle.eval(contextId);
await bundle.eval(contextId);
}
}
}
Expand Down