Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/text node value #279

Merged
merged 3 commits into from May 7, 2021
Merged

Fix/text node value #279

merged 3 commits into from May 7, 2021

Conversation

wssgcg1213
Copy link
Member

Fix #244

  1. 给 Text 节点增加 nodeValue 的赋值和取值逻辑, 同 CharaterData 的 data
  2. 修改构造函数 TextNode 为 Text

@wssgcg1213 wssgcg1213 requested review from andycall, answershuto and yuanyan and removed request for andycall and answershuto May 7, 2021 03:05
answershuto
answershuto approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@answershuto answershuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wssgcg1213 wssgcg1213 merged commit c33ced4 into main May 7, 2021
@wssgcg1213 wssgcg1213 deleted the fix/text-node-value branch May 7, 2021 03:41
@AlienegraGeek AlienegraGeek mentioned this pull request Dec 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andycall andycall andycall approved these changes

@answershuto answershuto answershuto approved these changes

@yuanyan yuanyan Awaiting requested review from yuanyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React useState 不生效
3 participants
@wssgcg1213 @andycall @answershuto