Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SVGElement #338

Merged
merged 3 commits into from May 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions bridge/CMakeLists.txt
Expand Up @@ -119,6 +119,8 @@ if ($ENV{KRAKEN_JS_ENGINE} MATCHES "jsc")
bindings/jsc/DOM/elements/input_element.h
bindings/jsc/DOM/elements/object_element.cc
bindings/jsc/DOM/elements/object_element.h
bindings/jsc/DOM/elements/svg_element.cc
bindings/jsc/DOM/elements/svg_element.h
bindings/jsc/DOM/elements/script_element.cc
bindings/jsc/DOM/elements/script_element.h
bindings/jsc/KOM/performance.cc
Expand Down
46 changes: 46 additions & 0 deletions bridge/bindings/jsc/DOM/elements/svg_element.cc
@@ -0,0 +1,46 @@
/*
* Copyright (C) 2021 Alibaba Inc. All rights reserved.
* Author: Kraken Team.
*/

#include "svg_element.h"

namespace kraken::binding::jsc {


void bindSVGElement(std::unique_ptr<JSContext> &context) {
auto SVGElement = JSSVGElement::instance(context.get());
JSC_GLOBAL_SET_PROPERTY(context, "SVGElement", SVGElement->classObject);
}


std::unordered_map<JSContext *, JSSVGElement *> JSSVGElement::instanceMap{};

JSSVGElement::~JSSVGElement() {
instanceMap.erase(context);
}

JSSVGElement::JSSVGElement(JSContext *context) : JSElement(context) {}
JSObjectRef JSSVGElement::instanceConstructor(JSContextRef ctx, JSObjectRef constructor, size_t argumentCount,
const JSValueRef *arguments, JSValueRef *exception) {
auto instance = new SVGElementInstance(this);
return instance->object;
}

JSSVGElement::SVGElementInstance::SVGElementInstance(JSSVGElement *jsSVGElement)
: ElementInstance(jsSVGElement, "svg", false), nativeSVGElement(new NativeSVGElement(nativeElement)) {
std::string tagName = "svg";
NativeString args_01{};
buildUICommandArgs(tagName, args_01);

foundation::UICommandTaskMessageQueue::instance(context->getContextId())
->registerCommand(eventTargetId, UICommand::createElement, args_01, nativeSVGElement);
}

JSSVGElement::SVGElementInstance::~SVGElementInstance() {
::foundation::UICommandCallbackQueue::instance()->registerCallback([](void *ptr) {
delete reinterpret_cast<NativeSVGElement *>(ptr);
}, nativeSVGElement);
}

} // namespace kraken::binding::jsc
53 changes: 53 additions & 0 deletions bridge/bindings/jsc/DOM/elements/svg_element.h
@@ -0,0 +1,53 @@
/*
* Copyright (C) 2021 Alibaba Inc. All rights reserved.
* Author: Kraken Team.
*/

#ifndef KRAKENBRIDGE_SVG_ELEMENT_H
#define KRAKENBRIDGE_SVG_ELEMENT_H

#include "bindings/jsc/DOM/element.h"
#include "bindings/jsc/js_context_internal.h"

namespace kraken::binding::jsc {

void bindSVGElement(std::unique_ptr<JSContext> &context);

struct NativeSVGElement;

class JSSVGElement : public JSElement {
public:
static std::unordered_map<JSContext *, JSSVGElement *> instanceMap;
OBJECT_INSTANCE(JSSVGElement)
JSObjectRef instanceConstructor(JSContextRef ctx, JSObjectRef constructor, size_t argumentCount,
const JSValueRef *arguments, JSValueRef *exception) override;

class SVGElementInstance : public ElementInstance {
public:

SVGElementInstance() = delete;
~SVGElementInstance();
explicit SVGElementInstance(JSSVGElement *JSSVGElement);

NativeSVGElement *nativeSVGElement;

private:
JSStringHolder m_data{context, ""};
JSStringHolder m_type{context, ""};
};
protected:
~JSSVGElement();
JSSVGElement() = delete;
explicit JSSVGElement(JSContext *context);
};

struct NativeSVGElement {
NativeSVGElement() = delete;
explicit NativeSVGElement(NativeElement *nativeElement) : nativeElement(nativeElement){};

NativeElement *nativeElement;
};

} // namespace kraken::binding::jsc

#endif // KRAKENBRIDGE_SVG_ELEMENT_H
2 changes: 2 additions & 0 deletions bridge/bridge_jsc.cc
Expand Up @@ -21,6 +21,7 @@
#include "bindings/jsc/DOM/element.h"
#include "bindings/jsc/DOM/elements/image_element.h"
#include "bindings/jsc/DOM/elements/input_element.h"
#include "bindings/jsc/DOM/elements/svg_element.h"
#include "bindings/jsc/DOM/event.h"
#include "bindings/jsc/DOM/custom_event.h"
#include "bindings/jsc/DOM/gesture_event.h"
Expand Down Expand Up @@ -100,6 +101,7 @@ JSBridge::JSBridge(int32_t contextId, const JSExceptionHandler &handler) : conte
bindElement(m_context);
bindImageElement(m_context);
bindInputElement(m_context);
bindSVGElement(m_context);
bindWindow(m_context);
bindPerformance(m_context);
bindCSSStyleDeclaration(m_context);
Expand Down