Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/webview scroll #398

Merged
merged 28 commits into from
Jun 18, 2021
Merged

Fix/webview scroll #398

merged 28 commits into from
Jun 18, 2021

Conversation

answershuto
Copy link
Member

@answershuto answershuto commented Jun 7, 2021 •
edited
Loading

close #379
close #402

@answershuto answershuto changed the title [WIP]Fix/webview scroll Fix/webview scroll Jun 10, 2021
@openkraken-bot
Copy link

openkraken-bot bot commented Jun 16, 2021 •
edited
Loading

  • Total time cost(without paint and layout): 666.84ms ↓ (2%)
  • widget_creation_cost: 39.11ms ↓ (10%)
    • controller_properties_init_cost 0.00ms(0%)
    • view_controller_properties_init_cost 0.00ms(0%)
    • element_manager_init_cost 0.00ms(0%)
    • element_manager_property_init 0.00ms(0%)
    • root_element_property_init_cost 0.00ms(0%)
    • root_element_init_cost 0.00ms(0%)
    • create_viewport 0.00ms(0%)
    • bridge_init_cost 0.00ms(0%)
    • bridge_register_dart_method_cost 0.00ms(0%)
    • js_context_init_cost 0.00ms(0%)
    • native_method_init_cost 0.00ms(0%)
    • polyfill_init_cost 0.00ms(0%)
  • First Bundle Load: 626.735ms ↓ (2%)
    • js_bundle_load_cost 0.00ms(0%)
    • js_bundle_eval_cost 0.00ms(0%)
    • js_parse_time_cost 0.00ms(0%)
    • flush_ui_command_cost 20.00ms(0%) avg: 0.76ms↑ (39%)
    • create_element_cost 195.00ms(0%) avg: 0.01ms(0%)
    • js_host_class_get_property_cost 5734.00ms(0%) avg: 0.01ms(0%)
    • js_host_class_set_property_cost 2735.00ms(0%) avg: 0.02ms(0%)
    • js_host_class_init_cost 0.00ms(0%)
    • js_native_function_call_cost 1843.00ms(0%) avg: 0.03ms(0%)
    • create_text_node_cost 47.00ms(0%) avg: 0.01ms(0%)
    • create_comment_cost 116.00ms(0%)
    • dispose_event_target_cost 0.00ms(0%)
    • add_event_cost 341.00ms↓ (0%) avg: 0.04ms↑ (100%)
    • insert_adjacent_node_cost 356.00ms(0%) avg: 0.08ms(0%)
    • remove_node_cost 5.00ms(0%)
    • set_style_cost 2054.00ms(0%) avg: 0.01ms(0%)
    • dom_force_layout_cost 5.00ms(0%) avg: 13.50ms↓ (1%)
    • dom_flush_ui_command_cost 143.00ms(0%) avg: 0.54ms(0%)
    • set_properties_cost 860.00ms(0%) avg: 0.01ms(0%)
    • remove_properties_cost 0.00ms(0%)
  • Rendering: 66.62ms ↓ (0%)
    • flex_layout_cost 253.50ms↑ (0%) avg: 0.11ms↓ (9%)
    • flow_layout_cost 93.00ms↑ (12%) avg: 0.07ms↓ (14%)
    • intrinsic_layout_cost 124.00ms(0%) avg: 0.01ms(0%)
    • silver_layout_cost 0.00ms(0%)
    • paint_cost 1579.00ms↓ (10%) avg: 0.02ms(0%)

andycall
andycall requested changes Jun 18, 2021
View reviewed changes
bridge/bindings/jsc/DOM/event_target.cc Outdated Show resolved Hide resolved
@yuanyan yuanyan merged commit e4975d8 into main Jun 18, 2021
@yuanyan yuanyan deleted the fix/webview_scroll branch June 18, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanyan yuanyan yuanyan approved these changes

@andycall andycall andycall approved these changes

@wssgcg1213 wssgcg1213 Awaiting requested review from wssgcg1213

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

按照 webkit 设计，renderview 应该挂在 document 上 Kraken 0.7.3 WebView无法滚动问题
4 participants
@answershuto @yuanyan @wssgcg1213 @andycall