fix: fix kraken page reload. #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
andycall
force-pushed
the
fix/page_reload
branch
from
d28c304
to
80907ed
Compare
|
yuanyan
reviewed
Jun 16, 2021
andycall
force-pushed
the
fix/page_reload
branch
from
80907ed
to
3d1a1b4
Compare
yuanyan
approved these changes
Jun 17, 2021
temper357
approved these changes
Jun 18, 2021
anjihang
reviewed
Jul 6, 2021
| std::to_string(targetContextId) + std::string(": bridge have already exist.")) | ||
| .c_str()); | ||
| auto context = new kraken::JSBridge(targetContextId, printError); | ||
| contextPool[targetContextId] = context; | ||
| return poolIndex; |
There was a problem hiding this comment.
返回值有问题。
应该返回targetContextId。
现在只有首次加载能成功，后续加载都会失败
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复页面刷新的过程中，指令执行顺序错误的问题
Fixed #118