Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: <input> support inputmode #441

Merged
merged 5 commits into from
Jun 24, 2021
Merged

feat: <input> support inputmode #441

merged 5 commits into from
Jun 24, 2021

Conversation

yuanyan
Copy link
Contributor

@yuanyan yuanyan commented Jun 22, 2021

Close #2

@andycall andycall added this to In Progress in Browser Features via automation Jun 22, 2021
@yuanyan yuanyan requested review from wssgcg1213 and andycall and removed request for wssgcg1213 June 22, 2021 13:57
@andycall
Copy link
Member

还应该有测试

@yuanyan
Copy link
Contributor Author

yuanyan commented Jun 22, 2021

目前只能在手机模拟器里看到效果,所以测试用例无法体现

@yuanyan
Copy link
Contributor Author

yuanyan commented Jun 22, 2021

还应该有测试

可以补充了看下是否有报错

@andycall
Copy link
Member

是不是应该用一个手机来跑集成测试

@yuanyan yuanyan added this to the 0.9 milestone Jun 23, 2021
wssgcg1213
wssgcg1213 previously approved these changes Jun 23, 2021
@wssgcg1213
Copy link
Member

Looks like failed with CI.

@yuanyan
Copy link
Contributor Author

yuanyan commented Jun 24, 2021

Looks like failed with CI.

FAIL: clip 003
Message: Expected an screenshot is not equal with "snapshots/css/css-overflow/clip.ts.196bb9771" snapshot.

这个经常偶发失败

@yuanyan yuanyan merged commit 1a9d2fe into main Jun 24, 2021
@yuanyan yuanyan deleted the feat/inputmode branch June 24, 2021 13:00
Browser Features automation moved this from In Progress to Done Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

支持 <input inputmode="...">
4 participants