Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support maxlength #450

Merged
merged 12 commits into from Jul 1, 2021
Merged

feat: support maxlength #450

merged 12 commits into from Jul 1, 2021

Conversation

yuanyan
Copy link
Contributor

@yuanyan yuanyan commented Jun 25, 2021

Close #251

@temper357
Copy link
Contributor

temper357 commented Jun 29, 2021

修复 input 相关 bug:

  1. height 不生效。
  2. 修改 height, line-height, font-size 属性时 input size 未更新。
  3. 梳理 input 上 height, line-height 与 text height 优先级逻辑,height > max(line-height, text height) > text height。
  4. width 未设置时使用 10 倍 font-size 作为 default width 模拟浏览器效果。

@andycall andycall added this to In Progress in Browser Features via automation Jul 1, 2021
@wssgcg1213 wssgcg1213 merged commit f747769 into main Jul 1, 2021
@wssgcg1213 wssgcg1213 deleted the feat/input-maxlength branch July 1, 2021 11:41
Browser Features automation moved this from In Progress to Done Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

input 标签不支持 type=password, maxlength
4 participants