-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove targetId and elementManager in RenderBoxModel #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laceholder offset
…ove-targetid # Conflicts: # kraken/lib/src/css/box.dart
andycall
requested changes
Jul 1, 2021
wssgcg1213
previously approved these changes
Jul 1, 2021
andycall
previously approved these changes
Jul 1, 2021
andycall
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124
RenderBoxModel 上去除 targetId 与 elementManager 属性。
RenderStyle 上增加 viewportSize 属性,以便 RenderBoxModel 中进行 length 计算时 viewportSize 从 renderStyle 中获取。
RenderBoxModel 中涉及到重新创建新的 renderBoxModel 时需要从对应的 element 上 detach 和 attach 强依赖 element,包含以下两块逻辑:
为防止直接在 RenderBoxModel 上传入 element,通过闭包的方式将与 element 的操作逻辑传入,考虑到扩展性,通过 delegate 编程模式创建一个新的 ElementDelegate 类,通过属性传入 RenderBoxModel,上面包含所有 renderBoxModel 上要用到的方法。
由于 CI 测试经常报错,暂时 disable opacity 相关用例, opacity 样式的测试用例偶发报错 #459