Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct context pool index #477

Merged
merged 1 commit into from
Jul 8, 2021
Merged

fix: correct context pool index #477

merged 1 commit into from
Jul 8, 2021

Conversation

anjihang
Copy link
Contributor

@anjihang anjihang commented Jul 7, 2021 •
edited
Loading

修复一个问题：
1.JSContext被覆盖，contextPool[0]被重复赋值。
复现步骤：首次启动，打开一个kraken页面，contextPool[0]会被赋值，在当前kraken页面再打开一个kraken页面，此时contextPool[0]又会被赋一次值。

@yuanyan yuanyan requested a review from andycall July 8, 2021 06:05
@answershuto answershuto merged commit d0038a5 into openkraken:main Jul 8, 2021
@airingursb airingursb mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andycall andycall andycall approved these changes

@answershuto answershuto answershuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anjihang @andycall @answershuto