Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flex item of image with no size #520

Merged
merged 7 commits into from Aug 4, 2021
Merged

fix: flex item of image with no size #520

merged 7 commits into from Aug 4, 2021

Conversation

temper357
Copy link
Contributor

Closes #502

修复 flex item 为 image 且 image 无 size 时的几个 bug:

  1. 横轴 size 未按照 intrinsic ratio 自适应。
  2. 计算 flex-shrink 时需要循环进行 violation 的判断，如果所有 flex item 的 flex shrink 为 0 时未异常处理，导致死循环页面渲染不出来（本地生活项目发现的 bug)。
  3. 计算 flex-shrink 时 flex item 有 overflow scroll/hidden 元素时，size 为负导致报错（ Flex 布局报错 #502 issue)

@temper357 temper357 added this to the 0.9 milestone Jul 21, 2021
@andycall
Copy link
Member

关联 project

@temper357 temper357 added this to In Progress in Browser Features via automation Jul 21, 2021
@answershuto answershuto merged commit e7d6fa2 into main Aug 4, 2021
Browser Features automation moved this from In Progress to Done Aug 4, 2021
@answershuto answershuto deleted the fix/img-in-flexbox branch August 4, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andycall andycall andycall approved these changes

@answershuto answershuto answershuto approved these changes

@wssgcg1213 wssgcg1213 Awaiting requested review from wssgcg1213

@yuanyan yuanyan Awaiting requested review from yuanyan

Assignees
No one assigned
Labels
None yet
Projects
Browser Features
Done
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

Flex 布局报错
3 participants
@temper357 @andycall @answershuto