Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: override findProxyFromEnvironment #551

Merged
merged 2 commits into from
Aug 9, 2021
Merged

fix: override findProxyFromEnvironment #551

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ff06ea
fix: override findProxyFromEnvironment
anjihang Jul 30, 2021
e9c3847
Merge branch 'openkraken:main' into fix/http_overrides_find_proxy_fro…
anjihang Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions kraken/lib/src/foundation/http_overrides.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,15 @@ class KrakenHttpOverrides extends HttpOverrides {
return httpClient;
}

@override
String findProxyFromEnvironment(Uri url, Map<String, String>? environment) {
if (parentHttpOverrides != null) {
return parentHttpOverrides!.findProxyFromEnvironment(url, environment);
} else {
return super.findProxyFromEnvironment(url, environment);
}
}

bool shouldOverride(HttpClientRequest request) {
String? contextId = request.headers.value(HttpHeaderContextID);
return contextId != null && _contextIdToHttpClientInterceptorMap.containsKey(contextId);
Expand Down