New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: transition execution timing #559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty works before node attached
temper357
requested review from
andycall,
yuanyan,
wssgcg1213 and
answershuto
and removed request for
andycall and
yuanyan
August 4, 2021 04:10
temper357
changed the title
[WIP] fix: transition execution timing
fix: transition execution timing
Aug 4, 2021
andycall
reviewed
Aug 9, 2021
andycall
requested changes
Aug 9, 2021
…n-timing # Conflicts: # kraken/lib/src/css/style_declaration.dart
andycall
approved these changes
Aug 10, 2021
answershuto
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #523
Closes #515
修复 transition 动画的执行时机不对。
问题:
当前 Kraken 动画是在 style 设置过程中通过设置延时将 transition 延迟到下一帧执行,这带来几个问题:
transform: tranlate(100px, 0); transition: all 1s ease;
动画将不生效,因为 transform setStyle 时在 style 中找不到 transition。fix: