Feat: support window onerror and global error event #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answershuto
previously approved these changes
Aug 19, 2021
yuanyan
reviewed
Aug 21, 2021
| const ex = new Error('CustomErrorTest'); | ||
| window.onerror = function(event, sourceURL, line, column, error) { | ||
| expect(window.onerror).toBe(arguments.callee); | ||
| const ex = new Error('CustomErrorTest'); |
There was a problem hiding this comment.
测试 window.onerror 的代码需要独立在 jasmine 之外，因为 jasmine 也会监听 window.onerror，存在冲突
There was a problem hiding this comment.
移到外部就不冲突了？ 会特征判断？那是否只需要 window.onerror 就可以了，而且最好加注释说明下
There was a problem hiding this comment.
嗯，因为 onerror 的测试是需要直接给 JS 抛个异常，jasmine 直接就当作是测试失败了。
yuanyan
reviewed
Aug 21, 2021
| JSValueRef errorObjectValue = getObjectPropertyValue(ctx, eventType, eventInstance->object, &exception); | ||
| JSObjectRef errorObject = JSValueToObject(ctx, errorObjectValue, &exception); | ||
| JSValueRef messageValue = getObjectPropertyValue(ctx, "message", errorObject, &exception); | ||
| JSValueRef sourceURLValue = getObjectPropertyValue(ctx, "sourceURL", errorObject, &exception); |
There was a problem hiding this comment.
因为 w3c 标准在不同的引擎之间就是个摆设，Error 的 prototype 上定义了 fileName，lineNumber，无论是 V8 还是 JSC 都没实现。取而代之的是一些各自特有的 API。
There was a problem hiding this comment.
这里的代码是操作 Error 对象，而不是 ErrorEvent
yuanyan
reviewed
Aug 21, 2021
wssgcg1213
reviewed
Aug 25, 2021
andycall
force-pushed
the
feat/window_onerror
branch
from
94d1ab8
to
8493d33
Compare
answershuto
approved these changes
Aug 25, 2021
temper357
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #600