-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
重构 renderStyle,支持 <style> #656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuanyan
commented
Sep 3, 2021
•
edited
Loading
edited
- element 暴露 setInlieStyle 与 setRenderStyle,废弃 setStyle
- style 的 setProperty 操作默认放入pending队列,flush 才通过listener真正去同步到 renderStyle
wssgcg1213
previously approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will |
短期更考虑 css animation api,keyframes 虽然简单但才鸡肋了 |
yuanyan
requested review from
andycall,
answershuto,
temper357 and
wssgcg1213
September 30, 2021 04:58
andycall
reviewed
Nov 19, 2021
temper357
previously approved these changes
Nov 19, 2021
answershuto
approved these changes
Nov 19, 2021
andycall
approved these changes
Nov 19, 2021
可以将 0.9.1-dev.2 发布到 pub.dev 么,想尝试一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.