-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 fix: recycler view with overflow error #662
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
302eb2c
:art: fix: recycler view with overflow error
wssgcg1213 2544df9
:white_check_mark: test: the new effect is right
wssgcg1213 8647fae
:bug: fix: recycler remove item
wssgcg1213 989d570
:recycle: refactor: debounce scroll event trigger
wssgcg1213 d159a95
:recycle: chore: schedule frame
wssgcg1213 800cee6
:bug: fix: apply sticky sync
wssgcg1213 d8ec42f
:recycle: chore: improve code performance
wssgcg1213 c1b84bc
:recycle: chore: using dispatch
wssgcg1213 d2a0089
:bug: fix: image resize multi times if not on screen
wssgcg1213 89e5e99
:bug: fix: recycler view
wssgcg1213 718ef60
:bug: fix: sliver scroll event
wssgcg1213 cb6aeda
:bug: fix: recycler use render box
wssgcg1213 4e1b97e
:bug: fix: scroll width and scroll height, with sliver tests
wssgcg1213 0099bc5
:white_check_mark: test: add test spec snapshot
wssgcg1213 b97c070
:white_check_mark: test: add test case for insert before
wssgcg1213 b956e72
:recycle: chore: remove comment code
wssgcg1213 ccc1a21
:recycle: chore: update code preview
wssgcg1213 91b78cc
:art: Merge branch 'main' into fix/recycler-list-view
wssgcg1213 eec9be5
:bug: fix: sliver element scroll
wssgcg1213 0dba3f9
:bug: fix: reset x and y
wssgcg1213 743805c
:bug: fix: scrollX is not removed.
wssgcg1213 3104118
:bug: fix: clip set to false for recycler
wssgcg1213 bb97658
Merge branch 'fix/recycler-list-view' of github.com:openkraken/kraken…
wssgcg1213 e98267a
:bug: fix: not to dispose position
wssgcg1213 d7214d9
:art: chore: improve comments
wssgcg1213 4898e83
:iphone: chore: remove empty line.
wssgcg1213 8c154c1
:recycle: chore: remove unused method.
wssgcg1213 40a9242
:recycle: chore: remove empty line.
wssgcg1213 13ad55f
:recycle: chore: add comments for recycler.
wssgcg1213 c9ad04b
:art: chore: remove unused code.
wssgcg1213 b861c0a
:recycle: chore: rename insertSliverChild.
wssgcg1213 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-273 Bytes
(90%)
integration_tests/snapshots/css/css-display/sliver.ts.ff69f4bb2.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
launcher 里面 lineOffset 也没用了吧?看起来 lineOffset 定义了 0 传递进去就没了,目前应该没有指定起始位置的需求。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
跟 JSC API 对齐参数的原因吧, @andycall 看下还要不要
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对,参数是需要传递的,这里默认 0 没问题,我说调用的地方也去掉一下。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
调用的地方 @andycall 的意思应该是预留的, 给外层传递用的, 放在抽象类里面提供的是默认值