Feat/support querySelector and querySelectorAll #672

answershuto · 2021-09-10T07:49:21Z

close #41

yuanyan · 2021-09-10T12:30:48Z

bridge/polyfill/src/dom.ts

@@ -23,3 +23,199 @@ Object.defineProperty(document, 'body', {
  enumerable: true,
  configurable: false
 });
+
+
+// Some utility methods.


可以独立一个文件

yuanyan · 2021-09-10T12:31:36Z

bridge/polyfill/src/dom.ts

+
+
+// Some utility methods.
+let slice = function slice(arr: HTMLCollectionOf<Element>): Array<Element> {


这些工具方法在kraken下并不需要

yuanyan · 2021-09-10T12:33:12Z

bridge/polyfill/src/dom.ts

+  let els = temp.selectors;
+  selector = temp.ruleStr;
+
+  // Get By ID


By -> by, 所有注释都不太规范

yuanyan · 2021-09-10T12:33:37Z

bridge/polyfill/src/dom.ts

+  }
+
+  // Get By Attributes
+  if (attributes.length !== 0) {


没有对应的 testcase

yuanyan · 2021-09-17T05:57:43Z

bridge/polyfill/src/querySelector.ts

@@ -0,0 +1,175 @@
+function fetchSelector(str: string, regex: RegExp) {


querySelector.ts 文件名风格需要统一

wssgcg1213 · 2021-09-22T11:10:36Z

bridge/polyfill/src/query-selector.ts

+    selectors: str.match(regex) || [],
+    ruleStr: str.replace(regex, ' ')
+  };
+};


FunctionDeclaration 不需要分号结束

wssgcg1213 · 2021-09-22T11:10:49Z

bridge/polyfill/src/query-selector.ts

+
+  elements = elements.concat(tempElements);
+  return elements;
+};


wssgcg1213 · 2021-09-22T11:10:56Z

bridge/polyfill/src/query-selector.ts

+  }
+  let elements = this.querySelectorAll(selector);
+  return elements.length > 0 ? elements[0] : null;
+};


wssgcg1213 · 2021-09-22T11:11:35Z

integration_tests/specs/dom/nodes/document.ts

+      div.style.backgroundColor = item;
+      div.setAttribute('id', `id-${index}`);
+      document.body.appendChild(div);
+    })


wssgcg1213 · 2021-09-22T11:11:51Z

integration_tests/specs/dom/nodes/document.ts

+      div.style.backgroundColor = item;
+      div.setAttribute('id', `id-${index}`);
+      document.body.appendChild(div);
+    })


wssgcg1213 · 2021-09-22T11:12:04Z

integration_tests/specs/dom/nodes/document.ts

+      div.style.backgroundColor = item;
+      div.setAttribute('id', `id-${index}`);
+      document.body.appendChild(div);
+    })


wssgcg1213 · 2021-09-22T11:12:07Z

integration_tests/specs/dom/nodes/document.ts

+      div.setAttribute('id', `id-${index}`);
+      div.className = `class-${index} cc`;
+      document.body.appendChild(div);
+    })


wssgcg1213 · 2021-09-22T11:12:12Z

integration_tests/specs/dom/nodes/document.ts

+      div.setAttribute('id', `id-${index}`);
+      div.setAttribute('data-test', `attr-${index}`);
+      document.body.appendChild(div);
+    })


直接找个格式化工具吧

temper357 · 2021-09-23T08:47:18Z

bridge/polyfill/src/query-selector.ts

+  selector = temp.ruleStr;
+  // TODO: now only support "equal".
+  // Attributes. e.g. [rel=external].
+  temp = fetchSelector(selector, /\[.+?\]/g);


只支持 equal，正则是不是限定下 /[.+=.+]/g

讨论了下这个正则没问题，去掉TODO。

temper357 · 2021-09-23T08:52:29Z

integration_tests/specs/dom/nodes/document.ts

@@ -32,4 +32,468 @@ describe('Document api', () => {
    expect(document.all).not.toBeUndefined();
    expect(document.all.length).toBeGreaterThan(0);
  });
+
+  it('document querySelector cant find element', () => {


querySelector 和 querySelectorAll 的测试用例建议像 getElementByClassName 一样独立成文件，不用全部放在 document 中

answershuto · 2021-09-23T09:13:30Z

bridge/polyfill/src/query-selector.ts

+  selector = temp.ruleStr;
+
+  // Elements. e.g. header, div.
+  temp = fetchSelector(selector, /\w+/g);


讨论了下这个正则没问题。

answershuto added 7 commits September 10, 2021 14:46

feat: add querySelect polyfill.

59ece31

test: add querySelector test.

3b9c49d

test: add querySelectorAll test.

f29bcb0

fix: delete invalid code.

189692f

chore: remove console.log

366ef03

test: modify id of test.

d0e8649

chore: modify type.

b8f63e7

answershuto requested review from yuanyan, wssgcg1213, andycall and temper357 September 10, 2021 07:50

yuanyan reviewed Sep 10, 2021

View reviewed changes

bridge/polyfill/src/dom.ts Outdated

}

// Get By Attributes

if (attributes.length !== 0) {

Copy link

Contributor

yuanyan Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有对应的 testcase

answershuto changed the title ~~Feat/support querySelector and querySelectorAll~~ [WIP]Feat/support querySelector and querySelectorAll Sep 10, 2021

answershuto added 14 commits September 13, 2021 21:11

Merge branch 'main' into feat/support_querySelector

313c39c

feat: add querySelector.ts.

4a6458a

chore: modify comments.

f10eb73

chore: delete useless util function.

3730949

feat: add new file to index .

24bbdff

feat: modify querySelector.

3982398

feat: add getElementsByClassName.

e968047

chore: delete comments.

6c1b38b

feat: className property should be save in attributes.

fdba750

test: add test for getElementsByClassName

0d08b9e

test: add test for querySelector to find className.

a71c4c0

fix: getElementsByTagName should work with *.

3e8b490

fix: className shoud be class when set property of element.

888445c

test: add test for getElementsByTagName of *.

82c54a2

answershuto added 2 commits September 16, 2021 14:01

chore: add new line.

0100c1c

test: add querySelectorAll for query attrs.

afdce2a

answershuto changed the title ~~[WIP]Feat/support querySelector and querySelectorAll~~ Feat/support querySelector and querySelectorAll Sep 16, 2021

answershuto changed the title ~~Feat/support querySelector and querySelectorAll~~ [WIP]Feat/support querySelector and querySelectorAll Sep 16, 2021

answershuto added 5 commits September 16, 2021 15:35

test: add test for query href of querySelectorAll

f3a52a2

test: add test for querySelector when query href.

a7fc280

test: add test for absolute path of querySelector.

d23590b

fix: misjudged the URL to be class.

287d9ba

fix: modify select class.

eb355a2

answershuto changed the title ~~[WIP]Feat/support querySelector and querySelectorAll~~ Feat/support querySelector and querySelectorAll Sep 16, 2021

yuanyan reviewed Sep 17, 2021

View reviewed changes

feat: modify querySelector.ts to query-selector.ts

b2c5b8d

answershuto requested a review from yuanyan September 22, 2021 09:33

wssgcg1213 reviewed Sep 22, 2021

View reviewed changes

chore: delete semicolon.

34522ac

wssgcg1213 requested changes Sep 22, 2021

View reviewed changes

chore: modify the format.

affec47

answershuto requested a review from wssgcg1213 September 22, 2021 12:51

chore: modify the format.

a1f9413

wssgcg1213 previously approved these changes Sep 23, 2021

View reviewed changes

temper357 reviewed Sep 23, 2021

View reviewed changes

test: modify query-select to a separate file.

8ecd064

answershuto dismissed wssgcg1213’s stale review via 8ecd064 September 23, 2021 09:12

answershuto commented Sep 23, 2021

View reviewed changes

wssgcg1213 approved these changes Sep 23, 2021

View reviewed changes

temper357 approved these changes Sep 23, 2021

View reviewed changes

answershuto merged commit 28a5c77 into main Sep 23, 2021

answershuto deleted the feat/support_querySelector branch September 23, 2021 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/support querySelector and querySelectorAll #672

Feat/support querySelector and querySelectorAll #672

answershuto commented Sep 10, 2021

yuanyan Sep 10, 2021

yuanyan Sep 10, 2021

yuanyan Sep 10, 2021

yuanyan Sep 10, 2021

yuanyan Sep 17, 2021

answershuto Sep 22, 2021

wssgcg1213 Sep 22, 2021

wssgcg1213 Sep 22, 2021

wssgcg1213 Sep 22, 2021

wssgcg1213 Sep 22, 2021

wssgcg1213 Sep 22, 2021

wssgcg1213 Sep 22, 2021

wssgcg1213 Sep 22, 2021

wssgcg1213 Sep 22, 2021

wssgcg1213 Sep 22, 2021

temper357 Sep 23, 2021 •

edited

answershuto Sep 23, 2021

temper357 Sep 23, 2021

answershuto Sep 23, 2021



		// Some utility methods.
		let slice = function slice(arr: HTMLCollectionOf<Element>): Array<Element> {

		@@ -0,0 +1,175 @@
		function fetchSelector(str: string, regex: RegExp) {

Feat/support querySelector and querySelectorAll #672

Feat/support querySelector and querySelectorAll #672

Conversation

answershuto commented Sep 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

temper357 Sep 23, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

temper357 Sep 23, 2021 •

edited