feat: migrate to xcframework for ios build #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycall
requested review from
cnryb,
wssgcg1213,
temper357,
airingursb,
anjihang and
answershuto
cnryb
previously approved these changes
Sep 22, 2021
andycall
force-pushed
the
feat/ios-xcframework
branch
from
320eeef
to
6063841
Compare
wssgcg1213
reviewed
Sep 22, 2021
| @@ -368,10 +368,11 @@ task(`build-ios-kraken-lib`, (done) => { | |||
| stdio: 'inherit' | |||
| }); | |||
|
|
|||
| // geneate builds scripts for ARMV7, ARMV7S | |||
| // geneate builds scripts for ARMV7S | |||
There was a problem hiding this comment.
// Generate build scripts for armv7s
typo, 单复数, 大小写
wssgcg1213
reviewed
Sep 22, 2021
| const frameworkPath = `${targetDynamicSDKPath}/kraken_bridge.xcframework`; | ||
| mkdirp.sync(targetDynamicSDKPath); | ||
|
|
||
| // merge armv7 into armv8 |
There was a problem hiding this comment.
注释开头大写吧, armv8 是指 arm64? 尽量统一术语
|
And CI should pass. |
|
我试了下, debug 产物没有 dSYM 的情况下 Xcode (13.0) 会报错, copy 过来一个就通过了 |
wssgcg1213
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.