Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor: gesture scroll physics and auto determine. #750

Merged
merged 1 commit into from Oct 22, 2021
Merged

♻️ refactor: gesture scroll physics and auto determine. #750

merged 1 commit into from Oct 22, 2021

Conversation

wssgcg1213
Copy link
Member

  1. 重构了 scroll_physics, 删除大量不必要的 non-null casting (!)
  2. 支持在不同类型设备下自动判断 ScrollPhysics 类型, iOS 使用 BouncingScrollPhysics, Android 以及其它设备使用 ClampingScrollPhysics
  3. 支持覆盖默认的 ScrollPhysics 其 API 为
ScrollPhysics.scrollPhysicsFactory = (ScrollPhysics? parent) {
  // ...
  return CustomScrollPhysics();
};

cnryb
cnryb approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@cnryb cnryb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wssgcg1213 wssgcg1213 merged commit 01753dc into main Oct 22, 2021
@wssgcg1213 wssgcg1213 deleted the refactor/gestures branch October 22, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnryb cnryb cnryb approved these changes

@andycall andycall andycall approved these changes

@temper357 temper357 Awaiting requested review from temper357

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wssgcg1213 @cnryb @andycall