fix: support vue hot reload. #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
目前的代码执行 samples 中的 hello-vue 会闪退 |
answershuto
previously approved these changes
Oct 26, 2021
|
我这个是 ok 的 |
你用的是这个分支吗 |
|
使用 gh pr checkout 785 获取的代码。没有执行 clean 操作，跟这个会有关系吗？ |
|
需要重新编一下 bridge |
|
在一个新的位置 clone 了代码进行测试，仍然闪退。 控制台的输出是这个样子的 |
|
有没有 C++的崩溃堆栈 |
|
就真的是一闪就没了。控制台就那么点内容了。之前程序闪退之后还会有个框提示一下，这两次测试连提示框也没了。 |
|
@cnryb 修好了。window.postMessage 少了一个 return value。 |
answershuto
approved these changes
Oct 26, 2021
|
能够正常渲染了 |
cnryb
reviewed
Oct 26, 2021
| @@ -6,6 +6,7 @@ | |||
| #include "window.h" | |||
| #include "dart_methods.h" | |||
| #include "bindings/qjs/qjs_patch.h" | |||
| #include "bindings/qjs/dom/events/.gen/message_event.h" | |||
There was a problem hiding this comment.
看这个路径感觉怪怪的，没什么问题吧？
有两处 1、以 . 开头的目录， 2 目录名是 gen 感觉里面的东西像是用代码生成的
There was a problem hiding this comment.
使用了这里实现的代码生成器生成的代码
https://github.com/openkraken/kraken/tree/main/bridge/scripts/code_generator
cnryb
reviewed
Oct 26, 2021
| @@ -36,6 +37,7 @@ class Window : public EventTarget { | |||
| ObjectFunction m_scroll{m_context, m_prototypeObject, "scroll", scrollTo, 2}; | |||
| ObjectFunction m_scrollTo{m_context, m_prototypeObject, "scrollTo", scrollTo, 2}; | |||
| ObjectFunction m_scrollBy{m_context, m_prototypeObject, "scrollBy", scrollBy, 2}; | |||
| ObjectFunction m_postMessage{m_context, m_prototypeObject, "postMessage", postMessage, 3}; | |||
There was a problem hiding this comment.
postMessage 有 3 个参数，这个参考 Web 标准
There was a problem hiding this comment.
cnryb
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.