fix: min width with padding #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temper357
requested review from
andycall,
yuanyan,
wssgcg1213 and
answershuto
temper357
changed the title
|
这个 PR 的代码，能够修复 #822 中描述的问题 |
…-with-padding # Conflicts: # kraken/lib/src/rendering/box_model.dart
yuanyan
approved these changes
Nov 23, 2021
|
@yuanyan 这个 PR 里面有 fit 没看到 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #822
修复 width 不存在，minWidth 且 padding 存在时，layout width 计算错误 bug。
由于上述 Bug 存在，minWidth/minHeight, border 存在但是 width/height 不存在的已有测试用例截图有问题一并修复。