fix: should call disposeEventTarget sync to make sure dispose sync be… #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween c and dart.
yuanyan
previously approved these changes
Nov 13, 2021
andycall
force-pushed
the
feat/sync_dispose_event_target
branch
from
d3093ae
to
a5f58dd
Compare
wssgcg1213
force-pushed
the
feat/sync_dispose_event_target
branch
from
3f045be
to
d3093ae
Compare
temper357
approved these changes
Nov 18, 2021
yuanyan
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
异步调用 disposeEventTarget 会导致在极端的情况下，触发事件的同时，eventTarget 也同步被销毁。从而导致 emitUIEvent 导致 crash。
Fix：将 disposeEventTarget 改成同步调用，确保时序一致