fix: add negative length validation for non negative css value #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanyan
previously approved these changes
Dec 1, 2021
wssgcg1213
previously approved these changes
Dec 1, 2021
cnryb
reviewed
Dec 1, 2021
andycall
reviewed
Dec 1, 2021
| @@ -282,8 +290,8 @@ class CSSStyleDeclaration { | |||
| case MAX_WIDTH: | |||
| case MAX_HEIGHT: | |||
| if (normalizedValue != NONE && | |||
There was a problem hiding this comment.
margin 为负值也可能会有问题
|
margin 允许负值，对于 #931 (comment) 只需要删除 margin 非负值的 assert |
wssgcg1213
approved these changes
Dec 2, 2021
yuanyan
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #936
修复因未检验 padding 负值而产生报错。
Close #931
fix:
100xxxvw这种值也命中判断为 length 类型。