Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ads patch for rollout undo #71

Merged
merged 1 commit into from Oct 13, 2022

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Oct 12, 2022

Signed-off-by: Siyu Wang FillZpp.pub@gmail.com

Fix ads patch for rollout undo

fixes openkruise/kruise#1100

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
@FillZpp
Copy link
Member Author

FillZpp commented Oct 12, 2022

/approve

@FillZpp
Copy link
Member Author

FillZpp commented Oct 12, 2022

/cc @hantmac
And when do we plan to release the next v1.0.5?

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, hantmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hantmac
Copy link
Member

hantmac commented Oct 12, 2022

/cc @hantmac And when do we plan to release the next v1.0.5?

How about Friday? I have to collect the PRs in this release.

@FillZpp
Copy link
Member Author

FillZpp commented Oct 12, 2022

/cc @hantmac And when do we plan to release the next v1.0.5?

How about Friday? I have to collect the PRs in this release.

That's great, thank you. And please give this a /lgtm :)

@hantmac
Copy link
Member

hantmac commented Oct 13, 2022

/lgtm

@hantmac hantmac merged commit aa23984 into openkruise:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] advance daemonset can not undo to previous version
3 participants