Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lua scripts for istio #178

Merged
merged 2 commits into from Nov 6, 2023
Merged

Conversation

Kuromesi
Copy link
Contributor

Ⅰ. Describe what this PR does

Add lua scripts for istio.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #178 (ef561d8) into master (57f9853) will decrease coverage by 0.88%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   44.44%   43.56%   -0.88%     
==========================================
  Files          51       52       +1     
  Lines        5560     5672     +112     
==========================================
  Hits         2471     2471              
- Misses       2666     2778     +112     
  Partials      423      423              
Flag Coverage Δ
unittests 43.56% <ø> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controller/rollout/rollout_controller.go 10.95% <ø> (ø)

... and 11 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Signed-off-by: Kuromesi <blackfacepan@163.com>
Signed-off-by: Kuromesi <blackfacepan@163.com>
@zmberg
Copy link
Member

zmberg commented Nov 6, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Nov 6, 2023

/approve

@kruise-bot kruise-bot merged commit 07b7f20 into openkruise:master Nov 6, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants