EPBDS-13715 Upgrade to Groovy 4 #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurkom
approved these changes
Apr 14, 2023
| .append(" ") | ||
| .append(implementationChain); | ||
| return description.toString(); | ||
| return super.generateClassDescription() + " " + IMPLEMENTS + " " + implementationChain; |
There was a problem hiding this comment.
How many times IMPLEMENTS constant is used? Maybe it is better to inline it?
Also, implementationChain can be prefixed by .append(super.generateClassDescription()).append(" implements ");
| @@ -107,7 +107,7 @@ protected Set<String> getDefaultImports() { | |||
| } | |||
|
|
|||
| protected String generateClassDescription() { | |||
| return new StringBuilder(CLASS).append(" ").append(getSimpleClassName()).toString(); | |||
| return CLASS + " " + getSimpleClassName(); | |||
There was a problem hiding this comment.
The same as above with INTERFACE
yurkom
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.