Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return of property field. #254

Merged
merged 1 commit into from
Jan 27, 2015
Merged

Fix return of property field. #254

merged 1 commit into from
Jan 27, 2015

Conversation

xt0ph
Copy link
Contributor

@xt0ph xt0ph commented Jan 25, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.02% when pulling 6ee4e87 on 2cadz:3.2 into 2f9ffed on openlabs:3.2.

@sharoonthomas
Copy link

@mbehrle could you take a look at this patch please ?

@mbehrle
Copy link
Contributor

mbehrle commented Jan 26, 2015

Of course, will do ASAP. As we already discussed, originally this didn't work for me, but I will have to check again.

@mbehrle
Copy link
Contributor

mbehrle commented Jan 27, 2015

Confirming, that this PR is the correct solution. I was initially misguided by

Traceback (most recent call last):
...
return super(Translation, self).unique_key()
TypeError: 'tuple' object is not callable

but now looking at it it is more than clear...;)

Please merge.

sharoonthomas pushed a commit that referenced this pull request Jan 27, 2015
Fix return of property field.
@sharoonthomas sharoonthomas merged commit 23c4610 into openlabs:3.2 Jan 27, 2015
@sharoonthomas
Copy link

Thank you @mbehrle 👍

@sharoonthomas
Copy link

Thank you @2cadz for the PR and fixing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants