Update datatypes & validation #31

corwinc · 2017-11-20T08:34:11Z

Includes:

Updated datatypes that reflect new data model on prod (complaintNumber, postOfOccurrence, officerSeqID)
Bugfix for react-bootstrap-date-picker's default time offset
Validation for Int16, Int64, Dates, and alphanumeric strings

Note: Phone validation is NOT included for this PR b/c the validator module's validation requires a country code and the design / implementation to make this happen is more intensive than is worth getting ready for the demo.

UnsungHero97 · 2017-11-20T21:04:19Z

src/shared/Validation.js

+      const validInt = validator.isInt(input);
+
+      let validIntType = true;
+      if (parseInt(input, 10) < -32768 || parseInt(input, 10) > 32767) {


Avoid magic numbers. Create constants for these...

const INT_SHORT_SIGNED_MAX_VALUE = 32767; const INT_SHORT_SIGNED_MIN_VALUE = -32768;

UnsungHero97 · 2017-11-20T21:09:26Z

src/shared/Validation.js

      const idx = formatErrors.indexOf(FORM_ERRORS.INVALID_FORMAT);
-      if (input && !validator.isInt(input)) {
+      const validInt = validator.isInt(input);


validator only validates strings, and will throw an error otherwise, which could potentially cause a lot of problems. Either surround this with a try-catch, or ensure that input will be a string.

https://github.com/chriso/validator.js/blob/master/src/lib/util/assertString.js

Further, isInt takes a second optional parameter where you can specify a min and a max:

https://github.com/chriso/validator.js/blob/master/src/lib/isInt.js

I'd recommend removing the check below, and replace it with a single validator check:

const isValid = validator.isInt(input, { max: INT_SHORT_SIGNED_MAX_VALUE, min: INT_SHORT_SIGNED_MIN_VALUE })

UnsungHero97 · 2017-11-20T21:11:25Z

src/shared/Validation.js

+        validIntType = false;
+      }
+
+      if ((input && !validInt) || (input && !validIntType)) {


If input is falsy, then validator.isInt will either throw an Error or return false. Either way, this check seems redundant.

UnsungHero97 · 2017-11-20T21:12:00Z

src/shared/Validation.js

+    }
+    case 'int64': {
+      const idx = formatErrors.indexOf(FORM_ERRORS.INVALID_FORMAT);
+      const validInt = validator.isInt(input);


Same comment about isInt taking a second optional parameter where you can specify max and min.

UnsungHero97 · 2017-11-20T21:17:18Z

src/shared/Validation.js

+
+      let validIntType = true;
+      if (
+        parseInt(input, 10) < -9223372036854775808


Avoid magic numbers. Additionally, I recommend using Number.MAX_SAFE_INTEGER and Number.MIN_SAFE_INTEGER instead since we're validating JavaScript. They are not quite 64 bits, but are probably good enough for our use.

UnsungHero97 · 2017-11-20T21:21:34Z

src/shared/Validation.js

+      const idx = formatErrors.indexOf(FORM_ERRORS.INVALID_FORMAT);
+      const currentDate = (new Date()).toISOString();
+      const validDate = validator.isISO8601(input)
+        && validator.isBefore(input, currentDate);


'date' is generic, but validator.isBefore is a restriction that makes using 'date' not make much sense.

Enforcing isBefore belongs in the date picker widget, where it disables the ability to choose any date after "today", but I'm not sure if the widget supports it.

Theoretically, but there's a bug with it. pushtell/react-bootstrap-date-picker#139

UnsungHero97 · 2017-11-20T21:22:18Z

src/shared/Validation.js

+      const idx = formatErrors.indexOf(FORM_ERRORS.INVALID_FORMAT);
+      const valid = validator.isAlphanumeric(input);
+
+      if (input && !valid) {


I think checking valid is enough since validator will already have checked input.

UnsungHero97 · 2017-11-20T21:32:18Z

src/containers/form/FormContainer.js

-    const input = e;
+  handleDateInput = (e, section, name, formatErrors, setErrorsFn) => {
+    let input = e;
+    input = input.replace(/T(.*)$/g, 'T00:00:00.000Z');


This is hacky, but we're stuck dealing with a bad dependency.

However, I believe all of the properties that are Date only care about the day+month+year.

Can you try just removing everything after and including the T, basically submitting only 2017-11-20, and seeing if that works?

Fixed. The shorter date submits fine.

UnsungHero97

I found a bug outside of this PR. The DOB in ConsumerInfoView doesn't pass the format errors parameter to handleDateInput, so there's errors being logged:

Uncaught TypeError: Cannot read property 'slice' of undefined

UnsungHero97 · 2017-11-20T22:04:35Z

src/containers/form/FormContainer.js

-    const input = e;
+  handleDateInput = (e, section, name, formatErrors, setErrorsFn) => {
+    let input = e;
+    input = input.replace(/T(.*)$/g, 'T00:00:00.000Z');


You need to handle the case where the "clear" button was clicked, which means input will be null.

corwinc added 8 commits November 20, 2017 14:04

Update postOfOccurrence datatype & validation

8c35e38

Update officerSeqID datatype & validation

5b2c544

Add validation for Int16, 64

bbeade0

Set time to 000 in handleDateInput

0032ec6

Add date validation

542daae

Clean up

883b562

Validate alphanumeric values

5e28a9d

Clean up

d304cb0

corwinc requested a review from UnsungHero97 November 20, 2017 08:34

Clean up

1a6f3aa

corwinc mentioned this pull request Nov 20, 2017

Bugfix for background overflow #32

Merged

UnsungHero97 suggested changes Nov 20, 2017

View reviewed changes

corwinc added 8 commits November 21, 2017 10:08

Remove time on date input

e40f607

Use int max min consts, update validation

15529f2

Add try catch blocks, remove redundant input validation

4ed7745

Use Number const for int64

200e495

Handle errors

f293b80

Handle case where input is null when date is cleared

07b9813

Add updated date input handling & validation to dob

e16bbeb

Include validator in try block, clean up imports

73413a1

UnsungHero97 approved these changes Nov 21, 2017

View reviewed changes

UnsungHero97 merged commit 04a2d64 into develop Nov 21, 2017

UnsungHero97 deleted the bugfix/datatype-updates branch November 21, 2017 05:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update datatypes & validation #31

Update datatypes & validation #31

corwinc commented Nov 20, 2017 •

edited

Loading

UnsungHero97 Nov 20, 2017

corwinc Nov 21, 2017

UnsungHero97 Nov 20, 2017

corwinc Nov 21, 2017

UnsungHero97 Nov 20, 2017

corwinc Nov 21, 2017

UnsungHero97 Nov 20, 2017

corwinc Nov 21, 2017

UnsungHero97 Nov 20, 2017

corwinc Nov 21, 2017

UnsungHero97 Nov 20, 2017

corwinc Nov 21, 2017

UnsungHero97 Nov 20, 2017

corwinc Nov 21, 2017

UnsungHero97 Nov 20, 2017

corwinc Nov 21, 2017

UnsungHero97 left a comment

UnsungHero97 Nov 20, 2017

corwinc Nov 21, 2017

Update datatypes & validation #31

Update datatypes & validation #31

Conversation

corwinc commented Nov 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UnsungHero97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

corwinc commented Nov 20, 2017 •

edited

Loading