This repository has been archived by the owner on May 2, 2019. It is now read-only.
Update graceful-fs #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to merge this (and further PRs related to the build failures). |
To support the new caret (^) syntax used by some dependencies, npm needs to be updated before installing on Node 0.8. Updating the get-down module removes the dependency on the zlib package (using the built-in zlib module instead), which would not install/build with the latest npm.
tschaub
added a commit
that referenced
this pull request
Jun 13, 2014
Force an update of `npm` before installing dependencies. Packages whose dependencies are specified with caret syntax (e.g. `^3.2.1`) require parsing with [`semver@>=2.1.0`](isaacs/node-semver#41). This means [`npm@>=1.3.7`](npm/npm@f369647) is needed. Upgrading `npm` is required even if our versions are pegged. It is common for our transitive dependencies to use fuzzy version matching which draws in newer packages that use the `^` syntax. So, the first two changes here are unrelated to the build failure. The build failure is fixed by forcing an upgrade of `npm` on Travis and updating `get-down` so it doesn't depend on a `zlib` package that is incompatible with the latest `npm`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At 3.x,
graceful-fsshould only be used where it is explicitlyrequired (see isaacs/node-graceful-fs@08471b2). Updating in an effort to address transient build failures.