Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cesium.Globe.getHeight not defined in the externs #75

Closed
ahocevar opened this issue Sep 24, 2014 · 4 comments
Closed

Cesium.Globe.getHeight not defined in the externs #75

ahocevar opened this issue Sep 24, 2014 · 4 comments
Milestone

Comments

@ahocevar
Copy link
Member

This causes build errors in 3 places:

  • camera.js:320
  • camera.js:374
  • core.js:27
@ahocevar ahocevar added the bug label Sep 24, 2014
@elemoine
Copy link
Member

How to reproduce this? Do these errors happen when compiling the ol3cesium.js build?

@ahocevar
Copy link
Member Author

cc @schmidtk @wallw-bits - can you please clarify?

@klokan klokan modified the milestone: QA Sep 25, 2014
@schmidtk
Copy link
Contributor

Adding --jscomp_error missingProperties to the compiler options catches those errors. After adding the extern and setting checkTypes to a warning, I was at least able to compile ol3 + ol3-cesium + application and everything appears to work properly.

/**
 * @param {!Cesium.Cartographic} cartographic
 * @return {number|undefined}
 */
Cesium.Globe.prototype.getHeight = function(cartographic) {};

@gberaudo
Copy link
Member

This is surprising we do not get the error since missingProperties is enabled in our configuration.
Anyway, I added your fix to #82. So closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants