Tentative fix of combined compilation. #82
Conversation
| var billboards = new Cesium.BillboardCollection(); | ||
| var reallyCreateBillboard = function() { | ||
| var center = geometry.getCoordinates(); | ||
| var position = olcs.core.ol4326CoordinateToCesiumCartesian(center); | ||
| goog.isDefAndNotNull(image); |
There was a problem hiding this comment.
Wouldn't it be nicer to either goog.asserts.assert(goog.isDefAndNotNull(image));, or to wrap the block below in an if (goog.isDefAndNotNull(image)) {} block?
There was a problem hiding this comment.
Agree. I don't understand what calling goog.isDefAndNotNull(image) does here.
|
One minor comment, but looks good otherwise. |
| @@ -514,18 +514,18 @@ goog.require('olcs.core.OLImageryProvider'); | |||
| geometry = olGeometryCloneTo4326(geometry, projection); | |||
|
|
|||
| var imageStyle = style.getImage(); | |||
| var image = imageStyle.getImage(); | |||
| var image = imageStyle.getImage(1); // get normal density | |||
There was a problem hiding this comment.
Without openlayers/openlayers#2754 this change should make the compilation fail when building ol3cesium.js (make dist). So openlayers/openlayers#2754 is related to this PR.
| @@ -111,7 +111,7 @@ Cesium.BillboardCollection = function() {}; | |||
|
|
|||
| /** | |||
| * @typedef {{ | |||
| * image: string, | |||
| * image: (string|HTMLCanvasElement|HTMLVideoElement|Image), | |||
There was a problem hiding this comment.
Do we know that image can actually reference an HTMLCanvasElement or an HTMLVideoElement here?
There was a problem hiding this comment.
The Cesium docs state it can be an image, canvas (they define the type as Canvas, which I'm assuming is the same as HTMLCanvasElement?), URL, or callback. An HTMLVideoElement would likely fail.
|
Please update the ol3 sub-module and merge. |
Tentative fix of combined compilation.
See #77 (comment)