Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative fix for compiler errors when storing properties. #95

Merged
merged 1 commit into from
Oct 3, 2014
Merged

Tentative fix for compiler errors when storing properties. #95

merged 1 commit into from
Oct 3, 2014

Conversation

gberaudo
Copy link
Member

@gberaudo gberaudo commented Oct 3, 2014

Using a map for storing the primitive associated to a feature.
The Cesium extern gets a new property for Primitive for storing the associated feature id.

@gberaudo
Copy link
Member Author

gberaudo commented Oct 3, 2014

Should fix https://github.com/boundlessgeo/ol3-cesium/pull/88/files#diff-943498d3823ec05e1f8bb4905b243ac5R88.

@schmidtk , could you please check which closure compiler options you are using?
In olcs we use all the ones printed on the compiler command line help.
Are you using undocumented options?

@elemoine elemoine added this to the QA milestone Oct 3, 2014
@elemoine
Copy link
Member

elemoine commented Oct 3, 2014

This looks good to me.

gberaudo added a commit that referenced this pull request Oct 3, 2014
Tentative fix for compiler errors when storing properties.
@gberaudo gberaudo merged commit b928955 into openlayers:master Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants