Added support for named graphics for the canvas renderer #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 22, 2012 15:26
…d might result at a location where the edge of one feature intersects the interior of another. This is due to antialiasing on the hit context canvas which can't be turned off, unfortunately.
|
@ajkopinga Thanks for this great contribution. It doesn't happen often that the first patch of a new contributor is in such a good shape as yours. |
|
You're welcome. It's my first time using git(hub) as well. |
ahocevar
added a commit
that referenced
this pull request
Feb 22, 2012
| * type - {String} one of 'stroke', 'fill', or 'reset' | ||
| * style - {Object} Symbolizer hash | ||
| */ | ||
| setCanvasStyle: function(type, style) { |
There was a problem hiding this comment.
CAUTION: "setCanvasStyle" method is repeated!
See:
..\build\temp\lib\OpenLayers\Renderer\Canvas.js:445: WARNING - object literals cannot contain duplicate keys in ES5 strict mode
setCanvasStyle: function(type, style) {
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now possible to use named graphics for point symbols within layers using the canvas renderer. To see this: use examples/graphic-name.html?renderer=Canvas . This should now look and behave the same way as ?renderer=SVG .