Add missing maxZoom property in olx.view.FitGeometryOptions #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredj I'm starting to wonder how you found all these missing options ;-) any way we can add this to the automated check target? |
No need. We have @fredj for that :-) |
|
LOL |
|
Always use |
|
LGTM please merge |
|
I've found this while working on #3029; the closure-compiler has a new (and not ready to use) option (https://github.com/openlayers/closure-util/blob/master/compiler-options.txt#L184) that detects this kind of errors. |
|
ah interesting, thanks for the pointer @fredj |
|
That's true that we should be able to detect this kind of errors ... |
fredj
added a commit
that referenced
this pull request
Dec 9, 2014
Add missing maxZoom property in olx.view.FitGeometryOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.