Unregister viewport size listener on setTarget(null) #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit unregisters the viewport resize listener when setTarget(null) is called, and registers it when setTarget(target) is called, and when we don't have that listener registered yet. This prevents memory leaks where references to map objects are retained because of these viewport resize listeners.
When the tile queue loads a tile it registers a "change" listener on that tile. But currently that listener is not unregistered, unless the tile cache containing that tile fills up and "dipose" is called on that tile. This commit makes handleTileChange deregister the "change" listener on the tile, if the tile is now in "loaded" state.
|
Looks great @elemoine. Please merge. |
elemoine
pushed a commit
that referenced
this pull request
Apr 3, 2015
Unregister viewport size listener on setTarget(null)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the memory leak problem reported in #3292. It fixes the problem by unregistering the viewport resize listener when
setTarget(null)is called to removed the map from the map.@fredj, this PR is an alternative to #3300, making it unnecessary to have to call (and expose)
disposeon the map. You can just domap.setTarget(null); map = null;to make the map a candidate for garbage collection.This PR also adds a commit modifying the tile queue code to unregister "change" listeners the tile queue sets on tiles.
Please review.