Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] ol.Map dispose #3300

Closed
wants to merge 5 commits into from
Closed

[wip] ol.Map dispose #3300

wants to merge 5 commits into from

Conversation

fredj
Copy link
Member

@fredj fredj commented Mar 2, 2015

No description provided.

@fredj fredj force-pushed the dispose branch 4 times, most recently from 5b73121 to 5ef2fa2 Compare March 3, 2015 14:03
@fredj fredj force-pushed the dispose branch 4 times, most recently from b83d18b to 7cfbe8d Compare March 16, 2015 12:33
@fredj
Properly dispose all the dom nodes created by ol.Map
9014ffe
@fredj
Nullify the view in ol.Map#dispose
04de5a5 
It has the side effect to unlisten to the 'propertychange' events of the view.
@fredj
Nullify the layergroup in ol.Map#dispose
407ed48 
It has the side effect to unlisten to the 'propertychange' and 'change'
events of the layer group.
@elemoine elemoine mentioned this pull request Mar 30, 2015
Merged
@elemoine
Copy link
Member

elemoine commented Apr 4, 2015

With #3420 I think we can close this. @fredj please close if you agree.

@fredj fredj closed this Apr 7, 2015
@fredj fredj deleted the dispose branch January 18, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredj @elemoine