Fix WebGL image layer rendering on retina displays #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM |
This commit takes the device pixel ratio into account when calculating the matrix used to apply the image to the output canvas.
|
Thanks for the reviews. I just rebased the branch onto the current master. Will merge if Travis build passes. |
|
ping @elemoine |
elemoine
pushed a commit
that referenced
this pull request
Apr 13, 2015
Fix WebGL image layer rendering on retina displays
|
Thanks for the fix. Much appreciated. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit takes the device pixel ratio into account when calculating the matrix used to apply the image to the output canvas.
Fixes #3405.
While working on this I've realized about other pixel ratio-related issues:
forEachLayerAtPixel) doesn't work on hidpi devices, with neither the Canvas renderer nor the WebGL renderer.I'll create tickets for these issues.