Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #5890 from ahocevar/no-white-lines" #6022

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Oct 24, 2016

This reverts commit 5f18246, reversing
changes made to 004afa6.

Fixes #6015

Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this one, Andreas. If you don't see an immediate way of fixing, than revrting is OK for me.

I have added two minor comments which you may want to take.

Otherwise this looks good to me, please merge at will.

return [0, 0, 0];
},
getImage: function() {
return img;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also don't need the creation of the img any longer, do we?

var tilesToDraw = this.renderedTiles;
if (tilesToDraw.length == 0) {
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can still be reached, right?

@bartvde
Copy link
Member

bartvde commented Oct 25, 2016

Does this warrant a minor release or not?

This partially reverts commit 5f18246,
reversing most of the changes made to
004afa6.
@ahocevar ahocevar merged commit 767bec4 into openlayers:master Oct 25, 2016
@ahocevar ahocevar deleted the white-lines branch October 25, 2016 11:03
@marcjansen marcjansen added this to the v.3.19.1 milestone Oct 28, 2016
marcjansen pushed a commit that referenced this pull request Oct 28, 2016
Revert "Merge pull request #5890 from ahocevar/no-white-lines"
ahocevar added a commit to ahocevar/openlayers that referenced this pull request Oct 28, 2016
Revert "Merge pull request openlayers#5890 from ahocevar/no-white-lines"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants