-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Merge pull request #5890 from ahocevar/no-white-lines" #6022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you on this one, Andreas. If you don't see an immediate way of fixing, than revrting is OK for me.
I have added two minor comments which you may want to take.
Otherwise this looks good to me, please merge at will.
return [0, 0, 0]; | ||
}, | ||
getImage: function() { | ||
return img; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also don't need the creation of the img
any longer, do we?
var tilesToDraw = this.renderedTiles; | ||
if (tilesToDraw.length == 0) { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can still be reached, right?
Does this warrant a minor release or not? |
Revert "Merge pull request #5890 from ahocevar/no-white-lines"
Revert "Merge pull request openlayers#5890 from ahocevar/no-white-lines"
This reverts commit 5f18246, reversing
changes made to 004afa6.
Fixes #6015