Cache array length in ol.control.Attribution

[twpayne]

No description provided.

[fredj]

LGTM

[elemoine]

I've been wondering about this construct, i.e. separating variable assignments with comas without a heading var keyword. It turns out that this is using the JavaScript's Comma Operator, which is fine. But it is to be noted that:

var i = 1, ii = 10;

is not the same as:

var i, ii;
i = 1, i = 10;

In the second code block, i = 1, i = 10 is an actual expression that returns the value of the second operand.

[twpayne]

Interesting! Thanks.

For me, jslint complains about for (var i = 1, ii = 10; ...) so I've moved the var declarations out of the for statement.

[elemoine]

Same for me. So I also do like that var declarations are out of for statements.

Also, on a related note. I like

var someVarName0 = 0;
var someVarName1 = 1;
var someVarName2 = 2;
var someVarName3 = 3;
var someVarName4 = 4;

I find this ok:

var a, b, c, d;

But I dislike:

var someVarName0 = 0,
      someVarName1 = 1,
      someVarName2 = 2,
      someVarName3 = 3,
      someVarName4 = 4;

Just a matter of taste, but I find the last construct less readable, especially when combining declarations of initialized and uninitialized variables.

[twpayne]

Regarding var declarations, I have exactly the same tastes as you :)

[elemoine]

+1 from me. Thanks Tom.