Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example updates #842

Merged
merged 3 commits into from
Jun 28, 2013
Merged

Example updates #842

merged 3 commits into from
Jun 28, 2013

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Jun 28, 2013

The example documentation should not be limited to 1/3 of the row. On narrow windows, this becomes a very small space.

In addition, I'm making RAW the default mode for loading library sources. I find the on-the-fly compilation unusable and a frustrating default (when you forget to add ?mode=RAW).

On-the-fly compilation is a frustrating default.
The example documentation should not be restricted to 1/3 of the row unless there is something else consuming the other 2/3.
@tschaub
Copy link
Member Author

tschaub commented Jun 28, 2013

Minor layout changes here, so I'm merging.

tschaub added a commit that referenced this pull request Jun 28, 2013
Updates to example markup.
@tschaub tschaub merged commit f2ce4db into openlayers:master Jun 28, 2013
@tschaub tschaub deleted the examples branch June 28, 2013 19:15
@elemoine
Copy link
Member

Thanks Tim. It looks good. I may need to change some text in the Developer Guide now that the default is RAW for the example.

@twpayne
Copy link
Contributor

twpayne commented Jul 1, 2013

In addition, I'm making RAW the default mode for loading library sources. I find the on-the-fly compilation unusable and a frustrating default (when you forget to add ?mode=RAW).

I solved this problem by bookmarking examples/index.html?mode=RAW. This adds the ?mode=RAW to all the links to examples.

@tschaub
Copy link
Member Author

tschaub commented Jul 1, 2013

What are the reasons for having ADVANCED be the default? Apologies for merging this without review. I assumed it would be non-controversial (it seems odd to ask people to create a bookmark to avoid the inconvenience of a default).

@twpayne
Copy link
Contributor

twpayne commented Jul 1, 2013

ADVANCED is the default simply because it is Plovr's default, there's no other reason as far as I know,

@elemoine
Copy link
Member

elemoine commented Jul 1, 2013

+1 for RAW by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants