use url class throughout, remove redundant checks

openlayers · Jun 17, 2023 · 2050025 · 2050025
1 parent e6bf9d7
commit 2050025
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/src/ol/source/BingMaps.js b/src/ol/source/BingMaps.js
@@ -266,21 +266,20 @@ class BingMaps extends TileImage {
               tileCoord[2],
               quadKeyTileCoord
             );
-            let url = imageUrl;
+            const url = new URL(
+              imageUrl.replace('{quadkey}', quadKey(quadKeyTileCoord))
+            );
+            const params = url.searchParams;
             if (hidpi) {
-              url += '&dpi=d1&device=mobile';
+              params.set('dpi', 'd1');
+              params.set('device', 'mobile');
             }
-            url = url.replace('{quadkey}', quadKey(quadKeyTileCoord));
-            const uri = new URL(url);
-            const params = uri.searchParams;
-            if (placeholderTiles === true && params.has('n')) {
+            if (placeholderTiles === true) {
               params.delete('n');
-              url = uri.toString();
-            } else if (placeholderTiles === false && !params.has('n')) {
-              params.append('n', 'z');
-              url = uri.toString();
+            } else if (placeholderTiles === false) {
+              params.set('n', 'z');
             }
-            return url;
+            return url.toString();
           }
         );
       })