Merge pull request #15143 from tschaub/hit-detect-circle

Properly hit detect circles after updating size
openlayers · Sep 18, 2023 · 5075214 · 5075214
2 parents 70e6da2 + a518abb
commit 5075214
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/ol/style/RegularShape.js b/src/ol/style/RegularShape.js
@@ -505,6 +505,7 @@ class RegularShape extends ImageStyle {
     this.renderOptions_ = this.createRenderOptions();
     const size = this.renderOptions_.size;
     this.canvas_ = {};
+    this.hitDetectionCanvas_ = null;
     this.size_ = [size, size];
   }
 

diff --git a/test/browser/spec/ol/style/circle.test.js → test/browser/spec/ol/style/Circle.test.js b/test/browser/spec/ol/style/circle.test.js → test/browser/spec/ol/style/Circle.test.js
@@ -2,7 +2,7 @@ import CircleStyle from '../../../../../src/ol/style/Circle.js';
 import Fill from '../../../../../src/ol/style/Fill.js';
 import Stroke from '../../../../../src/ol/style/Stroke.js';
 
-describe('ol.style.Circle', function () {
+describe('ol/style/Circle', function () {
   describe('#constructor', function () {
     it('creates a canvas (no fill-style)', function () {
       const style = new CircleStyle({radius: 10});
@@ -126,8 +126,17 @@ describe('ol.style.Circle', function () {
         }),
       });
       expect(style.getRadius()).to.eql(10);
+
+      const hitImageBefore = style.getHitDetectionImage();
+      expect(hitImageBefore).to.be.an(HTMLCanvasElement);
+      expect(hitImageBefore.width).to.eql(20);
+
       style.setRadius(20);
       expect(style.getRadius()).to.eql(20);
+
+      const hitImageAfter = style.getHitDetectionImage();
+      expect(hitImageAfter).to.be.an(HTMLCanvasElement);
+      expect(hitImageAfter.width).to.eql(40);
     });
   });
 });
diff --git a/...rowser/spec/ol/style/regularshape.test.js → ...rowser/spec/ol/style/RegularShape.test.js b/...rowser/spec/ol/style/regularshape.test.js → ...rowser/spec/ol/style/RegularShape.test.js
@@ -2,7 +2,7 @@ import Fill from '../../../../../src/ol/style/Fill.js';
 import RegularShape from '../../../../../src/ol/style/RegularShape.js';
 import Stroke from '../../../../../src/ol/style/Stroke.js';
 
-describe('ol.style.RegularShape', function () {
+describe('ol/style/RegularShape', function () {
   describe('#constructor', function () {
     it('can use rotateWithView', function () {
       const style = new RegularShape({