-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove glsl-unit #1079
Remove glsl-unit #1079
Conversation
Note that with this PR it's possible to remove the generated |
Why not forking glsl-unit or writing a simple node-based tool replacement? It would be more inline with our will to use Node for the build system. |
Modifying glsl-unit to fix the outstanding bugs requires a moderate understanding of compiler technology. glsl-unit doesn't even come with build instructions. I'm not familiar with node, and we have a dependency on Python for gjslint anyway. |
See also https://npmjs.org/package/glslmin I'm +1 for the python replacement |
Thanks for the pointer to glslmin. It doesn't seem to support templating, and templating is useful to avoid having to write boilerplate code. |
I don't like that we have both package.json and requirements.txt. This really demonstrates that we're going in any direction for the build system. I hope to find time to rewrite this in js. Please merge. |
I've updated the developer guide to mention requirements.txt. |
It looks like it should be possible to use glsl-unit with |
Agreed that the current lack of consensus on direction forward sucks. |
Unfortunately, the glsl-unit project (a GLSL minifier and templating system) seems to be dead. There are a number of outstanding bugs, the project has not been touched for a year and a half, and the original developer has moved on. The generated output is incompatible with IE11 (see #1051).
This PR adds a simple drop-in replacement for glsl-unit. It preserves the templating system (useful) and does simple minification, which works as well as GLSL unit for our simple shaders.