Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: ol/control/Control setMap does not allow for undefined #12758

Closed
jumpinjackie opened this issue Sep 15, 2021 · 0 comments · Fixed by #12759
Closed

TypeScript: ol/control/Control setMap does not allow for undefined #12758

jumpinjackie opened this issue Sep 15, 2021 · 0 comments · Fixed by #12759
Labels
bug

Comments

@jumpinjackie
Copy link
Contributor

Describe the bug
The setMap method of the Control class does not allow passing in undefined in TypeScript.

If you look at the underlying code in this method, it is clear that this.map_ being set/get can be undefined

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to pass undefined to setMap of any Control instance.

Expected behavior

It should be allowed, instead the TypeScript compiler will error: Argument of type 'undefined' is not assignable to parameter of type 'PluggableMap'
jumpinjackie added a commit to jumpinjackie/openlayers that referenced this issue Sep 15, 2021
@jumpinjackie
openlayers#12758: Allow undefined to be passed to control setMap(). C…
67d885d 
…onsequently the return type of getMap() now can also be undefined as well.
@jumpinjackie jumpinjackie mentioned this issue Sep 15, 2021
Merged
ahocevar added a commit that referenced this issue Sep 17, 2021
@ahocevar
Merge pull request #12759 from jumpinjackie/fix/control-typings
0d06f7b 
#12758: Allow undefined to be passed to control setMap(). Also fix type of getMap()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@jumpinjackie