Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify interaction options and cluster source options optional #15840

Closed
KyllianGautier opened this issue May 17, 2024 · 3 comments
Closed

Modify interaction options and cluster source options optional #15840

KyllianGautier opened this issue May 17, 2024 · 3 comments

Comments

@KyllianGautier
Copy link

Modify interaction options are required in the constructor, but all others interactions have optional options.
Same case for the cluster source.

Describe the solution you'd like
Make the Modify interaction options and the cluster source options optional.

@mike-000
Copy link
Contributor

Modify requires either source or features and throws an error "The modify interaction requires features, a source or a layer" if not supplied (the reference to layer seems to be outdated). Options should not be optional for Draw, a valid type is required. The docs for ClusterSource are incorrect as it also throws a runtime error if source is missing.

@KyllianGautier
Copy link
Author

@mike-000 Oh that's true, thanks, I fixed on my side.

@mike-000
Copy link
Contributor

I think the ClusterSource runtime error is a bug and the docs are correct as the error also occurs if the documented setSource(null) is used. That means no options are mandatory and the options parameter can be optional. I have created #15842 to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants